Use custom cors configuration

[hequ]

This is a:

• Feature request or change
• Bug report

Current behavior (if any)

Serverless-finch will override s3 bucket CORS configuration or it does not touch the configuration at all.

Proposed behavior

User can provide custom CORS configuration for the bucket the same way as bucketPolicyFile works.

Proposed implementation details (optional)

Add new configuration setting bucketCorsConfiguration which would be the path to cors configuration .json file.

I have a proposal about how this could work if this is something that could be considered to be added in the future.

Justification

The project I'm currently working needs special cors configuration for the SPA to work correctly. We use serverless-finch but we have had to disable the cors configuration override since it would break our deployment every time. It would be great to manage the CORS settings with finch as well.

[fernando-mc]

If you think this is a use case not currently covered well enough by:

--no-config-change and the bucketPolicyFile option I'm open to a PR @hequ.

[hequ]

If you think this is a use case not currently covered well enough by:

--no-config-change and the bucketPolicyFile option I'm open to a PR @hequ.

Sorry, I have not (for some reason) seen this comment until now. I'll see if I can take some time to submit a PR for this. :)

[fernando-mc]

@hequ Awesome! Thank you! As long as you take a look at those two options and confirm for me that it'll be adding new functionality here I'm 100% open to this. Sounds like a good addition from first glance that I don't think we have in the plugin.

[github-actions]

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀