Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cors): custom config file #160

Merged
merged 1 commit into from
Mar 7, 2022
Merged

feat(cors): custom config file #160

merged 1 commit into from
Mar 7, 2022

Conversation

mikejpeters
Copy link
Collaborator

Allow specifying a custom CORS configuration file

resolves #88, supersedes #103

Allow specifying a custom CORS configuration file

resolves #88
@mikejpeters mikejpeters requested a review from Shereef March 7, 2022 21:14
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #160 (266b464) into master (775f0e5) will increase coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
+ Coverage   84.75%   85.01%   +0.26%     
==========================================
  Files           6        6              
  Lines         341      347       +6     
==========================================
+ Hits          289      295       +6     
  Misses         52       52              
Impacted Files Coverage Δ
lib/configure.js 87.17% <ø> (ø)
lib/plugin.js 91.73% <100.00%> (+0.13%) ⬆️
lib/validate.js 59.21% <100.00%> (+2.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 775f0e5...266b464. Read the comment docs.

@mikejpeters mikejpeters merged commit d9461b6 into master Mar 7, 2022
@mikejpeters mikejpeters deleted the custom-cors-file branch March 7, 2022 21:38
@mikejpeters mikejpeters mentioned this pull request Mar 7, 2022
Closed
@github-actions
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use custom cors configuration
2 participants