Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for custom CORS file #103

Closed
wants to merge 3 commits into from
Closed

Conversation

gipsh
Copy link

@gipsh gipsh commented Jun 2, 2020

Background

The CORS config is hardcoded on resources. For a project i need to use a different CORS config.
Same problem mentioned on issue #88

Proposed changes

  • support for custom json cors file (like policy.json but for cors)

Proposed reviewers (optional)

[@ mentions of other contributors]

@gipsh gipsh mentioned this pull request Jun 2, 2020
2 tasks
@fernando-mc
Copy link
Owner

Hi @gipsh! Thanks for the PR, looks like a good one - can you potentially add some documentation on how this works? I can't merge it in without something in the readme explaining how it works. That also helps me test it.

@Shereef
Copy link
Collaborator

Shereef commented Feb 26, 2022

@gipsh Are you able to add some documentation and maybe some tests ? if you will work on the tests please wait for #144 to be merged first

Please also rebase off of master

Thanks so much

@mikejpeters
Copy link
Collaborator

Thank you for the pull request, it was helpful for #160 which includes your changes in addition to updating the docs and tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants