Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox 48 subarray returns the wrong thing #131

Closed
amasad opened this issue Aug 17, 2016 · 5 comments
Closed

Firefox 48 subarray returns the wrong thing #131

amasad opened this issue Aug 17, 2016 · 5 comments

Comments

@amasad
Copy link

amasad commented Aug 17, 2016

Firefox 48 includes a regression in Uint8Array.prototype.subarray which makes it return the full array instead of the subarray. We can probably catch it in typedArraySupport

var Buffer = require("buffer").Buffer
var b = new Buffer(100)
document.write(b.subarray(50, 100).length); // expected: 50, actual: 100

On RequireBin

@amasad
Copy link
Author

amasad commented Aug 17, 2016

I'm curious why is Firefox the only browser not in the saucelabs tests?

@kkHAIKE
Copy link

kkHAIKE commented Aug 17, 2016

may be new version fix it
#97

@rubensayshi
Copy link

seems to be fixed with updated browserify

@amasad
Copy link
Author

amasad commented Aug 17, 2016

Oh ok, the folks at Mozilla also mentioned it's fixed with the new browserify. Now the problem is with webpack 1.x

@amasad amasad closed this as completed Aug 17, 2016
@feross
Copy link
Owner

feross commented Aug 18, 2016

@amasad Glad you got this figured out. Btw, Firefox is tested, but the badge was having some issues updating recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants