-
-
Notifications
You must be signed in to change notification settings - Fork 231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove DataView, just do bitops #8
Comments
See discussion here: browserify/sha.js@91649a6#commitcomment-4964325 |
Wow, looks like it's better to just get rid of the DataView and do bit ops manually! cc @dominictarr @substack @maxogden Perf before:
Perf after:
Size Before:
Size after:
|
Published as 2.0.2. |
Wat!? how come that is faster! |
No idea! My guess is that DataView isn't used much in production code yet, so the browsers haven't taken the time to optimize it heavily yet. |
Advantages:
The text was updated successfully, but these errors were encountered: