Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking on node v11. Pls add a check for globalThis before use #17

Closed
tm-ssingh opened this issue Feb 18, 2021 · 2 comments
Closed

Breaking on node v11. Pls add a check for globalThis before use #17

tm-ssingh opened this issue Feb 18, 2021 · 2 comments

Comments

@tm-ssingh
Copy link

Could you please review this issue and just add a check before using globalThis. As its not supported on node v11, my project is breaking. Thank you
@ckolobov ckolobov mentioned this issue Feb 18, 2021
Closed
3 tasks
@mrzalyaul mrzalyaul mentioned this issue Feb 19, 2021
Closed
@tm-ssingh
Copy link
Author

so any solution? Can the owner merge the fixes suggested by other people?

@fangbinwei fangbinwei mentioned this issue Mar 19, 2021
Closed
@feross
Copy link
Owner

feross commented Mar 22, 2021

A new version that removes globalThis has been released as 1.2.3.

@feross feross closed this as completed Mar 22, 2021
@iliapolo iliapolo mentioned this issue Jun 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@feross @tm-ssingh