BREAKING: Remove built-in copy of standard
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feross
force-pushed
the
remove-standard
branch
4 times, most recently
from
5f1a654
to
ac7e149
Compare
`standard` is no longer bundled with snazzy. You must install `standard` manually alongside `snazzy`. Run `npm install standard --save-dev` to get a copy of `standard`, then run `standard | snazzy` where you previously used to ran `snazzy`. Though this takes more steps, it's better because it allows the user to control the exact version of `standard` that gets used. And for users who were piping into `snazzy` all along, this means a quicker install, since an extra copy of `standard` will not get installed.
ungoldman
reviewed
Apr 7, 2017
bin/cmd.js
Outdated
| } | ||
| }) | ||
|
|
||
| process.stdout.on('error', function () {}) |
There was a problem hiding this comment.
I thought that I introduced that line to prevent a bug in Node.js, but I can't find the commit where I introduced it. This line was been in the codebase since the initial commit.
I'll remove it and see if anything breaks! 😅
|
@feross just one comment, otherwise looks good. Also might want to bump node versions in |
|
What if And then var outputFormatter
try {
outputFormatter = require(moduleNameFromConfig)
} catch (e) {
outputFormatter = normalDefaultOutput
} |
|
Thanks for the review, @ungoldman! @jsumners I'm hesitant to add config options to |
|
7.0.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
standardis no longer bundled with snazzy. You must installstandardmanually alongsidesnazzy.Run
npm install standard --save-devto get a copy ofstandard, then runstandard | snazzywhere you previously used to ransnazzy.Though this takes more steps, it's better because it allows the user to control the exact version of
standardthat gets used. And for users who were piping intosnazzyall along, this means a quicker install, since an extra copy ofstandardwill not get installed.