Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More consistent controls #566

Merged
merged 2 commits into from
May 23, 2016
Merged

More consistent controls #566

merged 2 commits into from
May 23, 2016

Conversation

feross
Copy link
Member

@feross feross commented May 23, 2016

Tried to match the YouTube player UI more closely. There's still work to do, but this is a huge improvement for consistency:

screen shot 2016-05-22 at 21 59 22

Compare to:

screen shot 2016-05-22 at 22 15 54

  • Increased size of all controls
  • All buttons consistently get lighter on hover, without redundant css
  • Play button moves to left, just like YouTube
  • Time tweaks: thinner font, less verbose (0:xx instead of 00:xx, and omit hours when they're 0)
  • Bigger volume slider nub
  • Show back/forward buttons in top left on Windows/Linux, when in player
    • So it's consistent with OS X version, and the back button doesn't move around
    • Also, there are technically situations in which the forward button is needed from the player
      • Like if you start creating a torrent from the player, then go back, then want to go forward again
    • Make the background of the header bar transparent since it's mostly empty and looks terrible otherwise

This is what it looks like on Windows:

screen shot 2016-05-22 at 22 12 47

@dcposch
Copy link
Contributor

dcposch commented May 23, 2016

LGTM!

the other changes are really subtle, but putting the play button on the far left definitely feels cleaner

also, nice job aligning it with the back arrow, that looks pro

@feross feross merged commit 7d4c86e into master May 23, 2016
@feross feross deleted the ui-improvements branch May 23, 2016 21:49
mathiasvr pushed a commit to mathiasvr/webtorrent-desktop that referenced this pull request May 26, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants