Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron 1.4.0 #926

Merged
merged 1 commit into from
Sep 16, 2016
Merged

Electron 1.4.0 #926

merged 1 commit into from
Sep 16, 2016

Conversation

feross
Copy link
Member

@feross feross commented Sep 16, 2016

The changes that are relevant to us are:

  • Upgrade to Chrome 53.
  • Upgrade to Node 6.5.0.
  • Add support for titleBarStyle: 'hidden-inset' on OS X 10.9.

The last item should improve our UI on OS X 10.9 since we use 'hidden-inset'. I don't know what it looked like before.

@feross feross merged commit c8087b5 into master Sep 16, 2016
@feross
Copy link
Member Author

feross commented Sep 16, 2016

Thanks @Flet!

@feross feross deleted the electron-1.4.0 branch September 16, 2016 22:42
@dcposch
Copy link
Contributor

dcposch commented Sep 17, 2016

I think this broke the console in a weird way, but only when running from Spectron.

  1. Run the integration tests, but add a wait(100e3) somewhere to give yourself time
  2. Open DevTools. Go to the Console
  3. Notice the Console is empty. If you type anything and hit enter, it just disappears. The console is broken.
  4. npm install electron@1.3.5
  5. Repeat steps 1-3. The console works this time.

???

@feross
Copy link
Member Author

feross commented Sep 17, 2016

@dcposch Can you open an issue on the Electron repo?

This doesn't actually seem to affect the tests running correctly, right? I just ran through them on Electron 1.4.0 and it worked fine.

Up to you if you think we should revert.

@lock lock bot locked as resolved and limited conversation to collaborators May 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants