Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should amend set compositions to unknown rather than incomplete? #161

Closed
mmarseu opened this issue Apr 15, 2024 · 3 comments · Fixed by #160
Closed

Should amend set compositions to unknown rather than incomplete? #161

mmarseu opened this issue Apr 15, 2024 · 3 comments · Fixed by #160
Assignees

Comments

@mmarseu
Copy link
Collaborator

mmarseu commented Apr 15, 2024

As of now, the amend command creates a compositions entry with .aggregate == "incomplete".

The stated goal of this is to explicitly disclaim any completeness of the provided information in the interest of revealing known unknowns. Shouldn't the value then not rather be unknown, which expresses exactly that? "Incomplete" means: this SBOM is known to be incomplete, which it might not actually be. "Unknown" only says: we don't guarantee completeness, which seems to be exactly our intent.

@italvi
Copy link
Collaborator

italvi commented Apr 15, 2024

Agree, however, I would like to debate about not adding the bom.metadata.component to the list, as we should at least try to know our top-level dependencies. Your opinion?

@mmarseu
Copy link
Collaborator Author

mmarseu commented Apr 15, 2024

@italvi Seems reasonable to me.
In any case, this feature is a result of internal requirements and you're the person to set those requirements. So I don't get a say 😉

@italvi
Copy link
Collaborator

italvi commented Apr 15, 2024

But I'm the guy sitting in the ivory tower, so the view of an user is always valuable 😉.
So: Let's change incomplete to unknown and not add the metadata.component to the list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants