-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should amend
set compositions
to unknown
rather than incomplete
?
#161
Comments
Agree, however, I would like to debate about not adding the |
@italvi Seems reasonable to me. |
But I'm the guy sitting in the ivory tower, so the view of an user is always valuable 😉. |
As of now, the amend command creates a
compositions
entry with.aggregate == "incomplete"
.The stated goal of this is to explicitly disclaim any completeness of the provided information in the interest of revealing known unknowns. Shouldn't the value then not rather be
unknown
, which expresses exactly that? "Incomplete" means: this SBOM is known to be incomplete, which it might not actually be. "Unknown" only says: we don't guarantee completeness, which seems to be exactly our intent.The text was updated successfully, but these errors were encountered: