Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add-key option for generate key cli command #2611

Merged
merged 2 commits into from
Sep 8, 2021
Merged

add-key option for generate key cli command #2611

merged 2 commits into from
Sep 8, 2021

Conversation

solarw
Copy link
Contributor

@solarw solarw commented Sep 3, 2021

Proposed changes

add-key option for generate key cli command

Fixes

#2093

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • I am making a pull request against the develop branch (left side). Also you should start your branch off our develop.
  • Lint and unit tests pass locally with my changes and CI passes too
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that code coverage does not decrease.
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@solarw solarw force-pushed the feature/add_key_on_key_generation branch from 9dbe17b to 64a380e Compare September 3, 2021 11:32
DavidMinarsch
DavidMinarsch approved these changes Sep 6, 2021
View reviewed changes
Copy link
Contributor

@DavidMinarsch DavidMinarsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

5A11
5A11 reviewed Sep 7, 2021
View reviewed changes
tests/test_cli/test_generate_key.py Outdated
assert agent_keys.get(FetchAICrypto.identifier) == FETCHAI_PRIVATE_KEY_FILE


class TestGenerateKeyWithAddKeyWithConnection(AEATestCaseEmpty):
Copy link
Member

@5A11 5A11 Sep 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this test complete?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think so

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no test in this class.

Copy link
Member

@5A11 5A11 Sep 7, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you meant to subclass TestGenerateKeyWithAddKeyWithoutConnection above it?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry. missed this. added

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still haven't :)

@codecov-commenter
Copy link

Codecov Report

Merging #2611 (64a380e) into develop (8a42c16) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 64a380e differs from pull request most recent head 3b057cb. Consider uploading reports for the commit 3b057cb to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2611      +/-   ##
===========================================
- Coverage    99.75%   99.75%   -0.01%     
===========================================
  Files          520      520              
  Lines        35674    35686      +12     
===========================================
+ Hits         35588    35599      +11     
- Misses          86       87       +1
Flag Coverage Δ
unittests 99.75% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aea/cli/generate_key.py 100.00% <100.00%> (ø)
aea/test_tools/test_contract.py 94.59% <0.00%> (-1.36%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a42c16...3b057cb. Read the comment docs.

5A11
5A11 approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@5A11 5A11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DavidMinarsch DavidMinarsch merged commit 44c8b9e into develop Sep 8, 2021
@DavidMinarsch DavidMinarsch deleted the feature/add_key_on_key_generation branch October 15, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidMinarsch DavidMinarsch DavidMinarsch approved these changes

@5A11 5A11 5A11 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@solarw @codecov-commenter @DavidMinarsch @5A11