Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): check supported almanac contract version against deployed… #465

Merged
merged 10 commits into from
Jul 23, 2024

Conversation

Alejandro-Morales
Copy link
Contributor

No description provided.

@Alejandro-Morales Alejandro-Morales linked an issue Jul 18, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@Archento Archento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
One small comment about code robustness but if that's added I'm good with the changes.

python/src/uagents/network.py Show resolved Hide resolved
Copy link
Member

@Archento Archento left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now! Thanks

@jrriehl jrriehl merged commit 38f3035 into main Jul 23, 2024
9 checks passed
@jrriehl jrriehl deleted the almanac-version-check branch July 23, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Almanac contract version support
3 participants