Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add params for selecting teleop part for melodic #37

Merged
merged 1 commit into from
Apr 26, 2019

Conversation

708yamaguchi
Copy link
Contributor

I added params to teleop.launch.xml in order to select teleop part.

From ZebraDevs/fetch_ros#101 (review)

@708yamaguchi 708yamaguchi changed the title Add params for selecting teleop part Add params for selecting teleop part for melodic Apr 7, 2019
@cjds cjds self-requested a review April 26, 2019 19:49
@cjds cjds merged commit f8ff531 into ZebraDevs:melodic-devel Apr 26, 2019
@aparker-fetch
Copy link
Contributor

So this is already merged, but I still can't make it work on an 18.04 robot...
for instance:
rosparam get /teleop/use_head shows "false" after editing the launch or doing a rosparam set, but the head can still be moved with the controller.

@708yamaguchi
Copy link
Contributor Author

Did you build fetch_teleop with this commit (ZebraDevs/fetch_ros@bf353fe )?
This commit enables /teleop/use_head.

Also, I think that rosparam set is not effective to change teleop part because the bool param use_head in joystick_teleop.cpp can be changed only when editting launch file. (Namely, this parameter do not use dynamic_reconfigure.)
https://github.com/fetchrobotics/fetch_ros/blob/melodic-devel/fetch_teleop/src/joystick_teleop.cpp#L731

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants