Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review #5

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Review #5

wants to merge 8 commits into from

Commits on Dec 20, 2023

  1. Add keywords

    @KristjanESPERANTO
    KristjanESPERANTO committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    aefce9d View commit details
    Browse the repository at this point in the history

  2. Add .gitignore

    @KristjanESPERANTO
    KristjanESPERANTO committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    4475cb3 View commit details
    Browse the repository at this point in the history

  3. Update dependencies

    @KristjanESPERANTO
    KristjanESPERANTO committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    262e6a1 View commit details
    Browse the repository at this point in the history

  4. Add a picture that symbolizes TTS 

    This is good for module lists that add an screenshot for each module. Since this module is not visible, an symbol image is appropriate.
    @KristjanESPERANTO
    KristjanESPERANTO committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    37df9ae View commit details
    Browse the repository at this point in the history

  5. Fix typo MagicMirror²

    @KristjanESPERANTO
    KristjanESPERANTO committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    15d26c2 View commit details
    Browse the repository at this point in the history

  6. Review linting 

    - Remove deprecated rules
- Sort eslint config file
- Drop es6 - it's not necessary.
- Add "root": true - To avoid trouble with eslint configurations in higher directories.
- Remove eslint-plugin-import - it's already part of eslint-config-airbnb-base.
- Optimize script command "lint" in package.json
- Add script command "lint:fix" to package.json
- Finally run lint:fix
    @KristjanESPERANTO
    KristjanESPERANTO committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    084a03a View commit details
    Browse the repository at this point in the history

  7. Add a "readAtStartup" option

    @KristjanESPERANTO
    KristjanESPERANTO committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    74bb3da View commit details
    Browse the repository at this point in the history

  8. Better config example

    @KristjanESPERANTO
    KristjanESPERANTO committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    7532aee View commit details
    Browse the repository at this point in the history