Review #5
Open
Review #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is good for module lists that add an screenshot for each module. Since this module is not visible, an symbol image is appropriate.
- Remove deprecated rules - Sort eslint config file - Drop es6 - it's not necessary. - Add "root": true - To avoid trouble with eslint configurations in higher directories. - Remove eslint-plugin-import - it's already part of eslint-config-airbnb-base. - Optimize script command "lint" in package.json - Add script command "lint:fix" to package.json - Finally run lint:fix
|
@fewieden Are you still maintaining this module? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the great module! I have looked at the code and have made some changes. See the individual commits for details. If the PR is too big, let me know.