Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion #24

Closed
cowboysdude opened this issue Jan 9, 2019 · 4 comments
Closed

Suggestion #24

cowboysdude opened this issue Jan 9, 2019 · 4 comments

Comments

@cowboysdude
Copy link

Platform (Hardware/OS):
Any
Node version:
Current
MagicMirror version:
ANY
Module version:
Dev
Description of the issue:
Not an issue a suggestion for enhancement. Why not just make this a clock with an alarm clock? Makes much more sense. You could show the time and if there's an alarm show that under the time... Just and idea.

@fewieden
Copy link
Owner

fewieden commented Jan 9, 2019

Not sure if it is easy to implement, because the clock is rerendering every second, but when an aalarm fires this would repeat just the first second of the sound for the specified timeframe.

@cowboysdude
Copy link
Author

cowboysdude commented Jan 9, 2019 via email

@fewieden
Copy link
Owner

fewieden commented Jan 11, 2019

I'm not sure if I understood your last message

@cowboysdude
Copy link
Author

cowboysdude commented Jan 12, 2019

Yeah me either LOL Was on my phone and error correct is NOT your friend :) Let me see if I can figure out the code here :)

What I typed or thought I did was:
Couldn't the alarm be implemented in a different file and called by the clock js? Basically merging two files into one......BUT I see that that is just not practical at all...... seems like too much work for a simple alarm clock! :) I'm going to close this as it's not even an issue more a question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants