Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

~1/10ish games not recording #13

Closed
judehek opened this issue Jan 21, 2024 · 4 comments
Closed

~1/10ish games not recording #13

judehek opened this issue Jan 21, 2024 · 4 comments

Comments

@judehek
Copy link

judehek commented Jan 21, 2024

hey, I've been playing a lot, and I noticed strangely that roughly 10% of games don't record. I tried to replicate with debug in practice tool and I found out that sometimes it falsely detects the game as a spectator game and the recorder shuts down. any ideas on this? not the end of the world but can be annoying

@FFFFFFFXXXXXXX
Copy link
Owner

Yeah, I am aware about that bug, it's really annoying.
I didn't have a way to reproduce it until finally added some proper logging last week.
But I am now working on a fix.

@FFFFFFFXXXXXXX
Copy link
Owner

I am pretty sure release 1.16.1 should fix the issue.

@FFFFFFFXXXXXXX
Copy link
Owner

The issue is that sometimes the ingame API reports that a game is a spectator game even though it isn't. I think it is some weird race condition where the API has started but some settings or configuration are not fully loaded yet.
I hope there are no weird edge cases I missed.

@judehek
Copy link
Author

judehek commented Jan 21, 2024

seems working so far, thanks!

@judehek judehek closed this as completed Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants