Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert to msvcrt.dll as LIBC on MINGW #790

Merged
merged 3 commits into from Jun 9, 2020
Merged

Revert to msvcrt.dll as LIBC on MINGW #790

merged 3 commits into from Jun 9, 2020

Commits on Jun 5, 2020

  1. Revert to msvcrt.dll as LIBC on MINGW 

    ffi-1.13.0 switched FFI::Library::LIBC from msvcrt.dll to ucrtbase.dll
as part of ffi#779 in commit c674683 .

As described in ffi#788 ucrtbase.dll has behavioural changes which
shouldn't be released as part of a minor version change of ffi.
While the change makes sense for mswin, we revert it for mingw.

Fixes ffi#788
    @larskanis
    larskanis committed Jun 5, 2020
    Copy the full SHA
    f259139 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2020

  1. Revert usage of libc's time() on MINGW 

    Since libc is reverted to msvcrt.dll, we can use classic time() function again.
    @larskanis
    larskanis committed Jun 9, 2020
    Copy the full SHA
    90f4fca View commit details
    Browse the repository at this point in the history

  2. Add a spec regarding issue ffi#788

    @larskanis
    larskanis committed Jun 9, 2020
    Copy the full SHA
    f2d35a9 View commit details
    Browse the repository at this point in the history