Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Adds stop all sounds playing" #49

Merged
merged 1 commit into from
May 2, 2018
Merged

Conversation

ffont
Copy link
Owner

@ffont ffont commented May 2, 2018

Reverts #45 as it generates Uncaught ReferenceError: PropTypes is not defined error at load time. We should have automatic tests enabled (which I guess would have caught that).

@ffont ffont merged commit 798da5b into master May 2, 2018
@noVaSon
Copy link
Collaborator

noVaSon commented May 2, 2018

Ah this is strange.

The original PR deletes the PropTypes import, this is where this reference error came from.
Just add import { PropTypes } from 'prop-types'; and it should work again.

@ffont ffont deleted the revert-45-stop-playing branch May 3, 2018 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants