Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non existent JSONCacheDirectory silently fails json get from api #57

Closed
wolfcomp opened this issue Jun 24, 2021 · 0 comments
Closed

Non existent JSONCacheDirectory silently fails json get from api #57

wolfcomp opened this issue Jun 24, 2021 · 0 comments

Comments

@wolfcomp
Copy link

Describe the bug
Setting JSONCacheDirectory on a directory that does not exists causes reader to fail silently

To Reproduce
Steps to reproduce the behavior:

  1. Set JSONCacheDirectory to a directory that does not exist on the system
  2. Run application and see that no data can be read

Expected behavior
Successful saving of json data in said directory with creation of directory if not existing

Additional context
C# has an inbuilt method for directory creation in DirectoryInfo.Exists and DirectoryInfo.Create()

Current way of solving this is to just manually check if the directory is created before even initializing the memory reader but this function should be implemented into the library as a safety since some people can get stuck if they try to modify this without realizing this issue exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant