Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle memory items better #8

Open
Icehunter opened this issue Nov 15, 2016 · 4 comments
Open

handle memory items better #8

Icehunter opened this issue Nov 15, 2016 · 4 comments
Labels

Comments

@Icehunter
Copy link
Member

Icehunter commented Nov 15, 2016

@cybaersam Adding you here because you were working on a fix in the radar.

https://github.com/Icehunter/ffxivapp-memory/blob/master/FFXIVAPP.Memory/Reader.Actor.cs#L81

That is where I start looking at whether something was in the list previously or not; and determine which ones are new.

The main application fires the OnNewEntities events only 1 time; and sends a concurrentDictionary by ref. I think if radar was to listen to removed/added events it could handle that?

@Icehunter Icehunter added the bug label Nov 15, 2016
@Icehunter
Copy link
Member Author

Going to test this out now:

80d73cd

@cybaersam
Copy link

well if this works then we can remove the code from the radar ^_^

@vekien
Copy link
Contributor

vekien commented Nov 16, 2016

Not really, the Radar would still see dead enemies if they load in memory, which rank ones do as far as I'm aware?

@cybaersam
Copy link

cybaersam commented Nov 16, 2016

true.... though... if i remember correctly before heavensward they disappeared after a few seconds
haven't been very active with the app for a while when heavensward was released till now...

so if Icehunter's fix here gets that functionality back it should render my temp fix unnecessary in the radar...
well we will have to test it and see how it affects the radar and the info in the dictionaries

my goal is after this will be for the palace of the dead to better find hidden treasures (if that is even possible... i'm not sure if this information is in ram atleast i know its not in the dictionaries) and traps...
though for this i will need to be able to zoom in the radar... will try to get that after this is fixed ^_^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants