Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volcano plot with fixed ylim (scales) cannot be "freed up" with scales="free" #67

Closed
jjGG opened this issue Jan 19, 2024 · 5 comments
Closed

Comments

@jjGG
Copy link
Collaborator

jjGG commented Jan 19, 2024

Hoi Witold,

As you may have seen in the comments, one user SH realized that the volcanos are by default fixed on ylim.
Relaxing this with the scales parameter does not work .

-> in all these volcanos, the y-axis always has the same fixed length.
pl$volcano(scales = c("fixed"))
pl$volcano_plotly(scales = "free")
pl$volcano(scales = "free")
pl$volcano(scales = "free_y")

Gruess & bis am Dienstag
j

@wolski
Copy link
Collaborator

wolski commented Jan 22, 2024

@jjGG

I did run the examples in the prolfqua package ContrastsPlotter documentation:

cp$volcano(scales = "fixed")

image

cp$volcano(scales = "free")

image

Please try to reproduce an possible error using any of the example datasets provided with prolfqua.

@wolski wolski closed this as completed Jan 22, 2024
@wolski
Copy link
Collaborator

wolski commented Jan 23, 2024

@jjGG

I did limit the p.values to a minimum of 0.0001 ...
Now, there is a parameter minscorein the volcano function, which you can set to whatever you want.

@jjGG
Copy link
Collaborator Author

jjGG commented Jan 23, 2024

@wolski - super cool. Thanks for tghe fix!

@jjGG
Copy link
Collaborator Author

jjGG commented Jan 24, 2024

Hei Witold,

Leider funktioniert bei mir (prolfqua 1.1.5) der minscore parameter nicht. Eine Idee?

v3 <- plotter$volcano(minscore=c(1E-10))
Error in plotter$volcano(minscore = c(1e-10)) : 
  unused argument (minscore = c(1e-10))

@jjGG
Copy link
Collaborator Author

jjGG commented Jan 24, 2024

Super - Danke Witold.

Hat funktioniert. RTFM!
minscore =/ min_score

plotter <- contr$get_Plotter()
v2 <- plotter$volcano()
gridExtra::grid.arrange(v1$FDR,v2$FDR, ncol = 1)

# relax ylim
v3 <- plotter$volcano(min_score=1E-10)

gridExtra::grid.arrange(v2$FDR,v3$FDR, ncol = 1)


image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants