Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

commented out regex for excluding 'group' records #94

Merged
merged 3 commits into from
Jun 12, 2017

Conversation

dhoogest
Copy link
Collaborator

@dhoogest dhoogest commented Jun 8, 2017

closes #93

@crosenth
Copy link
Member

crosenth commented Jun 12, 2017

Great idea Dan. I reran taxtastic new_database and then built a taxtable using taxit taxtable --ranked --valid. Here is exactly what we will be getting
screen shot 2017-06-12 at 2 20 31 pm

@crosenth
Copy link
Member

Can you add a line in CHANGES.rst and link it to Issue #93

@dhoogest
Copy link
Collaborator Author

dhoogest commented Jun 12, 2017

@crosenth alrighty - I've added this as version 0.6.5. Wasn't sure if there were additional changes that you'd like to incorporate into a release, so just the one line in CHANGELOG.rst

@dhoogest
Copy link
Collaborator Author

Also, I'm fine with those three records at species level rank coming through. The benefit in including the species_group and species_subgroup nodes outweighs in my opinion.

@crosenth crosenth merged commit f8e356e into fhcrc:master Jun 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "group" from UNCLASSIFIED_REGEX_COMPONENTS in ncbi.py
2 participants