Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handler for locations out of coverage #21

Closed
christoph-morrison opened this issue Apr 13, 2020 · 0 comments · Fixed by #37
Closed

Improve error handler for locations out of coverage #21

christoph-morrison opened this issue Apr 13, 2020 · 0 comments · Fixed by #37
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@christoph-morrison
Copy link
Collaborator

Buienradar provides data for netherlands and (most of) germany, but if data for a location outside the covered area is requested, it will still fail with a HTTP/404 error, but delivers also an error message:

// 20200413155827
// https://cdn-secure.buienalarm.nl/api/3.4/forecast.php?lat=46.480962&lon=11.305530&region=de&unit=mm/u

{
  "success": false,
  "reason": "not in coverage"
}

If a location is out of coverage, the module should handle this accordingly and should not just fail (mostly) silently.

@christoph-morrison christoph-morrison added this to the 3.0 milestone Apr 13, 2020
@christoph-morrison christoph-morrison added the enhancement New feature or request label Apr 13, 2020
christoph-morrison pushed a commit that referenced this issue Apr 13, 2020
…show proper error message instead of simply a HTTP/404
@christoph-morrison christoph-morrison linked a pull request Apr 13, 2020 that will close this issue
@christoph-morrison christoph-morrison self-assigned this Apr 13, 2020
@christoph-morrison christoph-morrison modified the milestones: 3.0, 3.0.3 Apr 17, 2020
christoph-morrison pushed a commit that referenced this issue Apr 24, 2020
[BUIENRADAR-19] fixed and issue with an error when deleting the attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging a pull request may close this issue.

1 participant