Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return value of eval not tested #50

Closed
christoph-morrison opened this issue Apr 17, 2020 · 0 comments
Closed

Return value of eval not tested #50

christoph-morrison opened this issue Apr 17, 2020 · 0 comments
Assignees
@christoph-morrison
Labels
enhancement New feature or request Perl::Critic Issues raised by Perl::Critic waiting for release Is waiting for to be released
Milestone
3.0.6

Comments

@christoph-morrison
Copy link
Collaborator

mod-Buienradar/FHEM/59_Buienradar.pm

Line 108 in fd637a8

eval {

@christoph-morrison christoph-morrison added the enhancement New feature or request label Apr 17, 2020
@christoph-morrison christoph-morrison added this to the 3.0.6 milestone Apr 17, 2020
@christoph-morrison christoph-morrison self-assigned this Apr 17, 2020
@christoph-morrison christoph-morrison added the Perl::Critic Issues raised by Perl::Critic label Apr 17, 2020
@christoph-morrison christoph-morrison mentioned this issue Apr 20, 2020
Merged
christoph-morrison pushed a commit that referenced this issue Apr 20, 2020
#49 #50 #51 #52 #53 You can't depend upon the value of $@/$EVAL_ERROR…
8c19b03 
… to tell whether an eval failed, so I refactored to a more robust approach
@christoph-morrison christoph-morrison added the waiting for release Is waiting for to be released label Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christoph-morrison christoph-morrison

Labels
enhancement New feature or request Perl::Critic Issues raised by Perl::Critic waiting for release Is waiting for to be released
Milestone
3.0.6
Development

No branches or pull requests
1 participant
@christoph-morrison