Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined Alias #117

Closed
markkramerus opened this issue May 28, 2021 · 1 comment
Closed

Undefined Alias #117

markkramerus opened this issue May 28, 2021 · 1 comment
Assignees

Comments

@markkramerus
Copy link

GoFSH is generating this rule, although SNOMED_CT is undefined

* SNOMED_CT#442452003 "Life threatening severity (qualifier value)"

To see the example, use this URL in FSH Online, convert to JSON, then run GoFSH to convert back to FSH:

https://bit.ly/34rIMmU

I am planning to use this example at DevDays, so please give this priority.

@mint-thompson mint-thompson self-assigned this May 28, 2021
@markkramerus
Copy link
Author

Mint Thompson (They/Them/Theirs):theythem-teal: 9 hours ago
this is baffling. i'll take a look at it

Mark Kramer 9 hours ago
Thank you!

Nick Freiter (He/Him/His) 9 hours ago
But then if you run SUSHI on the version with SNOMED_CT, it runs without error right? I think it is using the SNOMED_CT CodeSystem, which is defined as part of the FHIR spec: https://www.hl7.org/fhir/codesystem-snomedct.json.html

Nick Freiter (He/Him/His) 9 hours ago
Notice the name, SNOMED_CT

Nick Freiter (He/Him/His) 9 hours ago
So it’s just preferring to use the name of a known resource over an alias

Mint Thompson (They/Them/Theirs):theythem-teal: 9 hours ago
oh, huh, you're right. the rule has SNOMED_CT, and it converts it to JSON in fsh online without an error

Nick Freiter (He/Him/His) 9 hours ago
Yeah if you check the url on the SNOMED_CT resource, it is http://snomed.info/sct. So it makes sense we would resolve that url to the existing resource. It’s a weird special case that that resource is defined in FHIR, but I think GoFSH is behaving correctly here

Mark Kramer 9 hours ago
That is weird. I never would have guessed. Do you want me to close the bug report?

Nick Freiter (He/Him/His) 8 hours ago
Yeah unless we want to do something special for snomed, we can close it as not a bug

Mark Kramer 8 hours ago
I seem to be reporting many not-a-bugs. 🥸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants