Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoFSH does not escape quotes in code definitions #95

Closed
cmoesel opened this issue Feb 11, 2021 · 0 comments · Fixed by #97
Closed

GoFSH does not escape quotes in code definitions #95

cmoesel opened this issue Feb 11, 2021 · 0 comments · Fixed by #97
Assignees
Labels
bug Something isn't working

Comments

@cmoesel
Copy link
Member

cmoesel commented Feb 11, 2021

GoFSH properly escapes quotes in some, but not all, circumstances. For example, given this CodeSystem:

{
  "resourceType": "CodeSystem",
  "status": "active",
  "content": "complete",
  "name": "MyCodeSystem",
  "id": "MyCodeSystem",
  "version": "0.1.0",
  "url": "http://example.org/CodeSystem/MyCodeSystem",
  "concept": [
    {
      "code": "foo",
      "display": "Foo",
      "definition": "The \"Foo\" system"
    }
  ],
  "count": 1
}

GoFSH produces this FSH:

CodeSystem: MyCodeSystem
Id: MyCodeSystem
* ^status = #active
* ^content = #complete
* ^version = "0.1.0"
* ^count = 1
* #foo "Foo" "The "Foo" system"

Note that the definition should be "The \"Foo\" system". I'm not sure, but I think maybe this is actually happening somewhere in one of SUSHI's toFSH() functions?

@cmoesel cmoesel added the bug Something isn't working label Feb 11, 2021
@jafeltra jafeltra self-assigned this Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants