Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename ExpressionWalker.traverse{Shape,TripleConstraint}s ? #12

Open
ericprud opened this issue Jul 24, 2024 · 0 comments
Open

rename ExpressionWalker.traverse{Shape,TripleConstraint}s ? #12

ericprud opened this issue Jul 24, 2024 · 0 comments
Assignees
Labels
question Further information is requested

Comments

@ericprud
Copy link

ericprud commented Jul 24, 2024

Version

extends-validation

Question

I think the rationale for the
ExpressionWalker.traverse{Shape,TripleConstraint}s names is that traversing a Shape means you walk the

  • TripleExpressions in that Shape,
  • ValueExpressions in that TripleConstraint.
    That said, I feel like traverse{TripleConstraint,ValueExpression}s might be more intuitive.

If we want the name to follow the ShExJ attributes, they are Shape.expression and TripleConstraint.valueExpr respectively.

@ericprud ericprud added the question Further information is requested label Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants