Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Medal of Honor Above and Beyond no upscale #32

Closed
kinemitor opened this issue Jul 22, 2021 · 5 comments
Closed

Medal of Honor Above and Beyond no upscale #32

kinemitor opened this issue Jul 22, 2021 · 5 comments

Comments

@kinemitor
Copy link

here is the log
openvr_mod.log

@fholger
Copy link
Owner

fholger commented Jul 22, 2021

Log looks fine, the mod is definitely doing something. Why do you say there is no upscale? What specifically is happening or not happening?

@kinemitor
Copy link
Author

After playing with the mod at 1823p with Target render at 1404p I removed the mod an lowered the resolution to 1404p to see how much better was the modded version over the same target render but to my surprise the native 1404 looked a lot better than the 1823p fsr mod

@fholger
Copy link
Owner

fholger commented Jul 22, 2021

I'm afraid I don't have the game, so I can't test this. I'll need more details. How exactly did the mod look worse? What specifically did you notice?

@kinemitor
Copy link
Author

kinemitor commented Jul 22, 2021

while the low res native was too blurry as expected, the game menu looked as expected but when the mod is active game menu gets a lot of jaggy edges, like if missing some aliasing, now in game I don't notice a problem, so my theory is that this implementation of fsr is being placed over the UI and that should not happen, maybe this is not fixable in a single dll mod, if that is what is happening the this game is one of those "partially compatible"

edit: there is a way to see what I mean in other games that support steamvr but aren't launched with steam client, some games from oculus store can do this if you launch their exe directly.
put this mod in one of those games, set 0.5 scale resolution target to make it very niticeable
close steam
then launch the exe
steamvr will open without steam and you will see a very ugly steamvr interface

@fholger
Copy link
Owner

fholger commented Jul 22, 2021

Yes, that's the gist of it. This mod can only be applied at the very end, after UI and any post-processing effect, whereas in a native integration FSR should be applied before UI and post-processing. Whether or not that's a problem depends very much on the particular game. But there is nothing I can do about it, either way.

@fholger fholger closed this as completed Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants