Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FiatType] Include Latin American fiat currencies #42

Open
andreujuanc opened this issue May 10, 2022 · 2 comments
Open

[FiatType] Include Latin American fiat currencies #42

andreujuanc opened this issue May 10, 2022 · 2 comments

Comments

@andreujuanc
Copy link

Hi,
We noticed that lots of the local fiat currencies in Latin America are missing from the type https://github.com/fiatconnect/specification/blob/main/swagger.yaml#L463

Is it possible to do a PR to add them? Will it be taken into account?
We'll reach out to the Valora team via email about this as well.

Thanks

@rafapolo
Copy link
Contributor

I'm glad to help out this one, since I've added the Brazilian one.

Country Currency ISO-4217
Argentina Argentine peso ARS
Bolivia Bolivian boliviano BOB
Brazil Brazilian real BRL
Chile Chilean peso CLP
Colombia Colombian peso COP
Ecuador United States dollar USD
Falkland Islands (UK) Falkland Islands pound FKP
French Guiana (France) European euro EUR
Guyana Guyanese dollar GYD
Paraguay Paraguayan guarani PYG
Peru Peruvian sol PEN
South Georgia Island (UK) Pound sterling GBP
Suriname Surinamese dollar SRD
Uruguay Uruguayan peso UYU
Venezuela Venezuelan bolivar VES

Just not sure if we should add ALL countries currencies at once, or if the CICO Providers would be the ones announcing the FIATs they support; otherwise we would have listed FIATs without Providers.

@andreujuanc
Copy link
Author

if the CICO Providers would be the ones announcing the FIATs

This could potentially be a breaking change in the spec. But I love this idea.

Just not sure if we should add ALL countries currencies at once

We can just compile and add whatever we all need. This can be the easiest and least disruptive.

These are currencies that we support and are not in your list:

Country Currency ISO-4217
Mexico Mexican peso MXN
Panama Panamanian balboa PAB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants