Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed nil returns from ScanUnspendOutputs implementations. #336

Merged
merged 5 commits into from
Feb 13, 2020
Merged

Removed nil returns from ScanUnspendOutputs implementations. #336

merged 5 commits into from
Feb 13, 2020

Conversation

hsequeda
Copy link
Collaborator

@hsequeda hsequeda commented Feb 7, 2020

Fixes #335

Changes:

  • Removed nil returns from ScanUnspendOutputs implementation.

Does this change need to mentioned in CHANGELOG.md?
no

Requires testing
Requires testing
no

@hsequeda
[qml_models] ref fibercrypto#335 - Replaced from "return nil" to NewS…
cd5d44f 
…kycoinTransactionOutputIterator(nil) the returns sentences when it's found a error in the ScanUnspendOutputs method implementations.
@hsequeda
[qml_models] ref fibercrypto#335 - Replaced from "NewSkycoinTransacti…
800f451 
…onOutputIterator(nil)" to 'return nil,err' the returns sentences when it's found a error in the ScanUnspendOutputs method implementations.
olemis
olemis requested changes Feb 8, 2020
View reviewed changes
src/models/modelWallets.go Show resolved Hide resolved
olemis
olemis requested changes Feb 8, 2020
View reviewed changes
Copy link
Contributor

@olemis olemis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stdevHsequeda why u adding so many files for such a tiny task ?

@olemis
Copy link
Contributor

olemis commented Feb 8, 2020

@stdevHsequeda why u adding so many files for such a tiny task ?

in vendor I mean

@olemis olemis added core Core interfaces skyfiber SkyFiber altcoin plugin labels Feb 8, 2020
@olemis olemis added this to the 0.27.0 milestone Feb 8, 2020
@hsequeda
Copy link
Collaborator Author

hsequeda commented Feb 8, 2020

@stdevHsequeda why u adding so many files for such a tiny task ?

in vendor I mean

I only add the vendor

@hsequeda
Copy link
Collaborator Author

hsequeda commented Feb 8, 2020

@stdevHsequeda why u adding so many files for such a tiny task ?

in vendor I mean

I only add the vendor
Do you want me to reverse those changes?

@olemis
Copy link
Contributor

olemis commented Feb 8, 2020

@stdevHsequeda no , I wander why these added at this point ?

@hsequeda
Copy link
Collaborator Author

hsequeda commented Feb 8, 2020

Review

@hsequeda
[bug] ref fibercrypto#335 - Modified TestRemoteWalletScanUnspentOutpu…
d9e4084 
…ts and TestLocalWalletScanUnspentOutputs test to increase the coverage.
@stdevMac stdevMac merged commit f65fded into fibercrypto:develop Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olemis olemis olemis requested changes

@stdevMac stdevMac stdevMac approved these changes

Assignees

@hsequeda hsequeda

Labels
core Core interfaces skyfiber SkyFiber altcoin plugin
Projects
None yet
Milestone
0.27.0
Development

Successfully merging this pull request may close these issues.

Remove nil returns of ScanUnspendOutputs implementation
3 participants
@hsequeda @olemis @stdevMac