Hardware wallet signer fixes #139 #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…AlDen_t139_hardware_wallet_signer ref fibercrypto#139
This reverts commit 533b214. ref fibercrypto#139
…let_signer Conflicts: .travis.yml Makefile vendor/github.com/skycoin/hardware-wallet-go/src/skywallet/messages.go vendor/github.com/skycoin/hardware-wallet-go/src/skywallet/skywallet.go vendor/github.com/skycoin/hardware-wallet-protob/go/google/protobuf/descriptor.pb.go vendor/github.com/skycoin/hardware-wallet-protob/go/messages.pb.go vendor/github.com/skycoin/hardware-wallet-protob/go/types.pb.go vendor/golang.org/x/sys/windows/syscall_windows.go vendor/golang.org/x/sys/windows/zsyscall_windows.go ref fibercrypto#139
address index for the spend output related for the input is used to find the priv/pub key pair ref fibercrypto#139
…hardware_wallet_signer Conflicts: Gopkg.lock ref fibercrypto#139
… GetLoadedAddresses ref fibercrypto#139
olemis
requested changes
Feb 18, 2020
| @@ -812,7 +816,31 @@ func NewWalletDirectory(dirPath string) *WalletDirectory { | |||
| type WalletDirectory struct { | |||
| // Implements WallentEnv interface | |||
| WalletDir string | |||
| wltService *SkycoinLocalWallet | |||
| wltService core.PersistibleSet | |||
There was a problem hiding this comment.
@stdevAlDen why this change ?
| "github.com/fibercrypto/fibercryptowallet/src/coin/skycoin/params" | ||
| "github.com/fibercrypto/fibercryptowallet/src/coin/skycoin/skytypes" | ||
| "github.com/fibercrypto/fibercryptowallet/src/core" | ||
| fce "github.com/fibercrypto/fibercryptowallet/src/errors" |
| return inputs, nil | ||
| } | ||
|
|
||
| func spendingOutputFromRemote(inputHash cipher.SHA256) (*readable.SpentOutput, error) { |
There was a problem hiding this comment.
Duplicated . Reuse the logic in Skycoin altcoin plugin .
| return | ||
| } | ||
|
|
||
| func readableTxn2Transaction(txn skytypes.ReadableTxn) (*coin.Transaction, error) { |
There was a problem hiding this comment.
Duplicated . Reuse Skycoin altcoin plugin code .
|
|
||
| func rawTxn2Transaction (txn skytypes.SkycoinTxn) (*coin.Transaction, error) { | ||
| buf, err := txn.EncodeSkycoinTransaction() | ||
| if err != nil { |
| @@ -0,0 +1,428 @@ | |||
| package hardware | |||
There was a problem hiding this comment.
Package name should match folder name . skywallet ?
| @@ -24,6 +24,11 @@ type WalletSet interface { | |||
| SupportedWalletTypes() []string | |||
| } | |||
|
|
|||
| type PersistibleSet interface { | |||
| @@ -618,6 +618,10 @@ func (walletM *WalletManager) signTxn(wltIds, address []string, source string, t | |||
| logWalletManager.WithError(err).Warnf("No signer %s for wallet %v", source, wlts[0]) | |||
| return nil | |||
| } | |||
| if suid, err := signer.GetSignerUID(); err != nil && wlts[0].GetId() == string(suid) { | |||
There was a problem hiding this comment.
condition should be err == nil , right ?
| } | ||
| return false | ||
| } | ||
| // FIXME: consider a double checking here instead of hadHwConnected |
There was a problem hiding this comment.
What about this FIXME tag ? Shall this remain ?
| @@ -0,0 +1,23 @@ | |||
| package util | |||
There was a problem hiding this comment.
Shouldn't this be under skywallet contrib package ?
olemis
changed the title
stdevAlDen
changed the title
…let_signer' into stdevAlDen_t139_hardware_wallet_signer
…Timeout vs SkycoinBlockchain.CacheTime
…freshTimeout and SkycoinBlockchain.CacheTime
…g signature of GetSpentOutput and GetAddress ... still WiP
This was referenced Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139
Changes:
vendor/github.com/SkycoinProject/skycoingit submodule, use it from vendors.GetInputs, previous cached value.EnumerateSignServicesfor local/remote wallet.TestTransactionSignInputFromDevicefor the hardware wallet signer.QSignerandSignerModelmodelsDoes this change need to mentioned in CHANGELOG.md?
yes
Requires changes in protobuf specs?
no
Requires testing
yes