Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code quality for SkyWallet contrib plugin for v1 #353

Closed
5 tasks done
olemis opened this issue Mar 9, 2020 · 0 comments · Fixed by #354
Closed
5 tasks done

Improve code quality for SkyWallet contrib plugin for v1 #353

olemis opened this issue Mar 9, 2020 · 0 comments · Fixed by #354
Assignees
@olemis @stdevAlDen
Labels
sign_api Altcoin API for signing transactions skywallet SkyWallet hardware wallet
Projects
FiberCrypto wallet - Iteration 1
Milestone
0.27.0

Comments

@olemis
Copy link
Contributor

olemis commented Mar 9, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
SkyWallet signer PR #253 for #139 was rushed to meet v0.27.0 deadline. Some code quality items were not enforced.

Describe the solution you'd like

  • Rename Remove PersistibleSet
  • Wrong condition check
  • FIXME comment in walleModel.data
  • Revert type of WalletDirectory.wltService , core.PersistibleSet=> SkycoinLocalWallet
  • Remove WalletDirectory.SetWltService

Additional context
Original work developed in PR #253 for #139 . More details in open review
@olemis olemis added sign_api Altcoin API for signing transactions skywallet SkyWallet hardware wallet labels Mar 9, 2020
@olemis olemis added this to To do in FiberCrypto wallet - Iteration 1 via automation Mar 9, 2020
@olemis olemis added this to the 0.27.0 milestone Mar 9, 2020
@olemis olemis changed the title Improve code quality for SkyWallet contrib plugin Improve code quality for SkyWallet contrib plugin for v1 Mar 9, 2020
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Mar 9, 2020
@stdevAlDen
fix error checking in walletManager signTxn ref fibercrypto#353
3224ab0
stdevAlDen added a commit to simelo/fibercryptowallet that referenced this issue Mar 9, 2020
@stdevAlDen
remove PersistibleSet ref fibercrypto#353
1051dfe
@stdevAlDen stdevAlDen mentioned this issue Mar 9, 2020
Merged
FiberCrypto wallet - Iteration 1 automation moved this from To do to Done Mar 10, 2020
olemis added a commit that referenced this issue Mar 10, 2020
@olemis
Merge pull request #354 from simelo/stdevAlDen_t353_improve_code_qual…
defa7e4 
…ity4hw_signer

Improve code quality for hw signer - fixes #353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olemis olemis

@stdevAlDen stdevAlDen

Labels
sign_api Altcoin API for signing transactions skywallet SkyWallet hardware wallet
Projects
FiberCrypto wallet - Iteration 1
  
Done
Milestone
0.27.0
Development

Successfully merging a pull request may close this issue.

Improve code quality for hw signer simelo/fibercryptowallet
2 participants
@olemis @stdevAlDen