Add options for the log in settings #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add settings's properties `logLevel` and `logOutput` Embedd the `Settings`'s content inside a `ScrollView` Add options inside **Global Settings** to select the log level and the log output Improve the general layout of the **Address Book** section
…allet into stdevCrow_Add_Options_for_the_Log_in_Settings
…allet into stdevCrow_Add_Options_for_the_Log_in_Settings
…evAntiD2ta_t298_Log_events_to_file
… Add some logs
… for log level This function returns a logrus.level from an enum identifier.
…b.com/simelo/FiberCryptoWallet into stdevCrow_Add_Options_for_the_Log_in_Settings
Add a new property `logOutputFile`
…evAntiD2ta_t298_Log_events_to_file
…pipeline Changes: - Add a enum for output options - In case that output is `File`, call to GetFileToLog is postponed to when outputFile option is get from the configuration options - Changes permission of file .log created to 0344 (old: 0600)
… when settings are saved When the output change from stderr to File(for example) the logs are written to the file with a weird format, in the other way, logs aren't written to the console
…guration options
…allet into stdevCrow_Add_Options_for_the_Log_in_Settings
…b.com/simelo/FiberCryptoWallet into stdevCrow_Add_Options_for_the_Log_in_Settings
stdevCrow
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #298 - Log app events to file
Changes:
ComboBoxto let the user choose between different log levelslogLevelandlogOutputLevelFromEnumenumfor log level (This function returns alogrus.levelfrom anenumidentifier)logOutputproperty's type tointlogOutputFile, in order to allow having an output log file with any name (even stdout or none) without conflictsoutputFile, related with the previous pointlogLevelandlogOutputComments about testing , should you have some