Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tasks.py:64-65: Handle errors in check_purchase. Report... #704

Closed
0pdd opened this issue Jan 20, 2019 · 1 comment
Closed

tasks.py:64-65: Handle errors in check_purchase. Report... #704

0pdd opened this issue Jan 20, 2019 · 1 comment
Assignees
@ArtemijRodionov
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue Health check feature report Put it to completed tasks temporary list for business

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jan 20, 2019

The puzzle 690-44aa8d80 from #690 has to be resolved:

shopelectro/shopelectro/tasks.py

Lines 64 to 65 in ce492b1

# @todo #690:60m Handle errors in check_purchase.
# Report failed attempts. Schedule it in the celery beat.

The puzzle was created by @artemiy312 on 20-Jan-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jan 20, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jan 20, 2019
@ArtemijRodionov
#690 #498 #497 Make the check_purchase work (#695)
ce492b1 
* Fix current implementation of selenium classes

* Create Input element class for selenium

* Implement fill_cotacts and make_order methods of OrderPage class

* Self-review fixes

* Create PaymentOptions enum

* Create Button class, implement OrderPage.select_payment_type

* Remove todo about payment_types

* Apply linter rules

* Self-review fixes

* Move PaymentOptions to shopelectro.models

* Fix a typo

* Apply linter rules

* Provide the comment for EnumMeta class.

* Remove excess import from base.py

* Fix typo

* Apply linter rules
This was referenced Jan 20, 2019
Closed
Closed
@ArtemijRodionov ArtemijRodionov added 1 hour typical issue size. It's one pdd hour 1 burning issue Health check feature labels Jan 20, 2019
@ArtemijRodionov ArtemijRodionov self-assigned this Jan 20, 2019
@ArtemijRodionov ArtemijRodionov mentioned this issue Jan 26, 2019
Merged
ArtemijRodionov added a commit that referenced this issue Jan 28, 2019
@ArtemijRodionov
#704 check purchase (#709)
a1e74b2 
* Create SuccessPage

* Assert success_page.is_success() in check_purchase

* Setup auto-retry for the check_purchase

* Create TGReport

* Review fixes

* Add the comment to check_purchase's report policy

* Apply linter rules

* Fix typos
@ArtemijRodionov ArtemijRodionov added the report Put it to completed tasks temporary list for business label Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue Health check feature report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArtemijRodionov @0pdd