Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tasks.py:66: Schedule check_purchase in the celery beat. #712

Closed
0pdd opened this issue Jan 28, 2019 · 1 comment
Closed

tasks.py:66: Schedule check_purchase in the celery beat. #712

0pdd opened this issue Jan 28, 2019 · 1 comment
Assignees
@ArtemijRodionov
Labels
1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix Health check feature report Put it to completed tasks temporary list for business

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jan 28, 2019

The puzzle 690-7e329879 from #690 has to be resolved:

shopelectro/shopelectro/tasks.py

Line 66 in a1e74b2

# @todo #690:30m Schedule check_purchase in the celery beat.

The puzzle was created by Artemiy on 28-Jan-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jan 28, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jan 28, 2019
@ArtemijRodionov
#704 check purchase (#709)
a1e74b2 
* Create SuccessPage

* Assert success_page.is_success() in check_purchase

* Setup auto-retry for the check_purchase

* Create TGReport

* Review fixes

* Add the comment to check_purchase's report policy

* Apply linter rules

* Fix typos
This was referenced Jan 28, 2019
Closed
Closed
@ArtemijRodionov ArtemijRodionov added 1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix Health check feature labels Jan 28, 2019
@ArtemijRodionov ArtemijRodionov self-assigned this Jan 28, 2019
@ArtemijRodionov ArtemijRodionov mentioned this issue Feb 8, 2019
Merged
ArtemijRodionov added a commit that referenced this issue Feb 11, 2019
@ArtemijRodionov
#712 #724 schedule check purchase (#725)
f9302aa 
* Schedule check_purchase

* Make SiteDriver a context manager

* Fix celery conf

* Add wait-for to celery workers

* Add .total_times to check-purchase.schedule

* Fix typo

* Review fixes

* Fix SiteDriver manager
@ArtemijRodionov ArtemijRodionov added the report Put it to completed tasks temporary list for business label Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix Health check feature report Put it to completed tasks temporary list for business
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArtemijRodionov @0pdd