Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

base.py:490: Move UTM_PRICE_MAP to an iterable Enum #714

Open
0pdd opened this issue Jan 29, 2019 · 5 comments
Open

base.py:490: Move UTM_PRICE_MAP to an iterable Enum #714

0pdd opened this issue Jan 29, 2019 · 5 comments
Assignees
@duker33
Labels
1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable easy new teammates can start with such issues to become familiar with project

Comments

@0pdd
Copy link
Collaborator

0pdd commented Jan 29, 2019

The puzzle 666-c099ca68 from #666 has to be resolved:

shopelectro/shopelectro/settings/base.py

Line 490 in 234023f

# @todo #666:30m Move UTM_PRICE_MAP to an iterable Enum

The puzzle was created by duker33 on 29-Jan-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Jan 29, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Jan 29, 2019
@duker33
#666 Init OOP arch for prices command (#705)
234023f 
* #255  Increase selenium timeout value

* #666  Create initial OOP structure for `price` command

* #666  Review fixes

* #666  Fix error in tests

* #666  Fix arch for File(s) classes
This was referenced Jan 29, 2019
Closed
Closed
@duker33 duker33 added 30 mins middle-sized issue. Usually a part of feature or a fix 3 we can defer this issue. But it'll good to implement it take it any teammate can take this issue and start working with it easy new teammates can start with such issues to become familiar with project cleanup everything that do project stronger, flexible, reusable labels Jan 29, 2019
@duker33
Copy link
Contributor

duker33 commented Jan 29, 2019

we already have some code with iterable enum

@duker33 duker33 removed the take it any teammate can take this issue and start working with it label Oct 29, 2019
@duker33 duker33 self-assigned this Oct 29, 2019
@duker33
Copy link
Contributor

duker33 commented Oct 29, 2019

related to #1004

@duker33
Copy link
Contributor

duker33 commented Oct 29, 2019 •
edited

it seems dataclass would be more good. But py3.7 is required for it

@duker33 duker33 added 1 burning issue and removed 3 we can defer this issue. But it'll good to implement it labels Oct 29, 2019
@duker33
Copy link
Contributor

duker33 commented Oct 29, 2019

task is required to cleanup new rss prices feed code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable easy new teammates can start with such issues to become familiar with project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd