Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

price.py:39-40: Refactor price command. Create Price... #666

Closed
0pdd opened this issue Dec 11, 2018 · 3 comments
Closed

price.py:39-40: Refactor price command. Create Price... #666

0pdd opened this issue Dec 11, 2018 · 3 comments
Assignees
@duker33
Labels
2 hours some big and monolith issue with hard decisions, discussions or bug with strong research 3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable

Comments

@0pdd
Copy link
Collaborator

0pdd commented Dec 11, 2018

The puzzle 661-ec781b69 from #661 has to be resolved:

shopelectro/shopelectro/management/commands/price.py

Lines 39 to 40 in 2f19548

# @todo #661:120m Refactor price command.
# Create Price class with it's own price processing.

The puzzle was created by duker33 on 11-Dec-18.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Dec 11, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Dec 11, 2018
@duker33
#661 Change utm for YaMarket's price.yml (#664)
2f19548 
* #661  Refactor constant name

* #661  Move utm patching to explicit data structure

* #661  Move utm patching to explicit data structure

* #661  Apply linter rules
@0pdd 0pdd mentioned this issue Dec 11, 2018
Closed
@duker33 duker33 assigned duker33 and unassigned duker33 Dec 11, 2018
@duker33 duker33 added 2 hours some big and monolith issue with hard decisions, discussions or bug with strong research 3 we can defer this issue. But it'll good to implement it take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable labels Dec 11, 2018
@duker33 duker33 removed the take it any teammate can take this issue and start working with it label Jan 21, 2019
@duker33 duker33 self-assigned this Jan 21, 2019
duker33 added a commit that referenced this issue Jan 21, 2019
@duker33
#666 Create initial OOP structure for price command
f2ec02a
@duker33 duker33 mentioned this issue Jan 21, 2019
Merged
duker33 added a commit that referenced this issue Jan 25, 2019
@duker33
#666 Review fixes
90772e4
duker33 added a commit that referenced this issue Jan 25, 2019
@duker33
#666 Fix error in tests
cfbdf21
duker33 added a commit that referenced this issue Jan 29, 2019
@duker33
#666 Fix arch for File(s) classes
f60f791
duker33 added a commit that referenced this issue Jan 29, 2019
@duker33
#666 Init OOP arch for prices command (#705)
234023f 
* #255  Increase selenium timeout value

* #666  Create initial OOP structure for `price` command

* #666  Review fixes

* #666  Fix error in tests

* #666  Fix arch for File(s) classes
This was referenced Jan 29, 2019
Open
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Jan 29, 2019

@0pdd 2 puzzles #714, #715 are still not solved.

@0pdd
Copy link
Collaborator Author

0pdd commented Feb 6, 2019

@0pdd 2 puzzles #714, #721 are still not solved; solved: #715.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
2 hours some big and monolith issue with hard decisions, discussions or bug with strong research 3 we can defer this issue. But it'll good to implement it cleanup everything that do project stronger, flexible, reusable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd