Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Меняем метку в yml #661

Closed
themygit opened this issue Dec 5, 2018 · 7 comments
Closed

Меняем метку в yml #661

themygit opened this issue Dec 5, 2018 · 7 comments
Assignees
@duker33
Labels
1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix from PO from product owner. It's hellxi x2 task's price doubled. Usually because of burning

Comments

@themygit
Copy link

themygit commented Dec 5, 2018

Меняем UTM метку в yml который отдается яндекс маркету https://www.shopelectro.ru/static/yandex.yml
напоминаю, что от этого фаила зависят и другие yml. в них не меняем.

https://www.shopelectro.ru/catalog/products/4023/?utm_source=YM&utm_medium=cpc&utm_content=akkumuliatory-270&utm_term=4023

utm_medium=cpc нужно сменить на utm_medium=cpc-market
@themygit themygit added the from PO from product owner. It's hellxi label Dec 5, 2018
@duker33 duker33 added 30 mins middle-sized issue. Usually a part of feature or a fix x2 task's price doubled. Usually because of burning 1 burning issue labels Dec 5, 2018
@duker33
Copy link
Contributor

duker33 commented Dec 5, 2018

i'll fix it in two iterations:

  • fast and dirty hack for production
  • good code with tests and review

duker33 added a commit that referenced this issue Dec 5, 2018
@duker33
#661 Minor yml fix
ac63746
@duker33
Copy link
Contributor

duker33 commented Dec 5, 2018

done fast fix at #657

duker33 added a commit that referenced this issue Dec 5, 2018
@duker33
#612 Fix inheritance (#657)
7aa2fa5 
* #612  Fix model fields inheritance problem

* #612  Grade refarm dep to 0.4.19

* #612  Minor autochange fix

* #657  Ignore duplicate code according to linter

* #661  Minor yml fix
duker33 added a commit that referenced this issue Dec 8, 2018
@duker33
#661 Refactor constant name
50a32b5
duker33 added a commit that referenced this issue Dec 8, 2018
@duker33
#661 Move utm patching to explicit data structure
2a07e7e
@duker33 duker33 mentioned this issue Dec 8, 2018
Merged
duker33 added a commit that referenced this issue Dec 10, 2018
@duker33
#661 Move utm patching to explicit data structure
1e910c2
duker33 added a commit that referenced this issue Dec 10, 2018
@duker33
#661 Apply linter rules
1b85dae
duker33 added a commit that referenced this issue Dec 11, 2018
@duker33
#661 Change utm for YaMarket's price.yml (#664)
2f19548 
* #661  Refactor constant name

* #661  Move utm patching to explicit data structure

* #661  Move utm patching to explicit data structure

* #661  Apply linter rules
This was referenced Dec 11, 2018
Closed
Closed
@0pdd
Copy link
Collaborator

0pdd commented Dec 11, 2018

@themygit 2 puzzles #666, #667 are still not solved.

@0pdd
Copy link
Collaborator

0pdd commented Dec 20, 2018

@themygit 2 puzzles #666, #679 are still not solved; solved: #667.

@0pdd
Copy link
Collaborator

0pdd commented Jan 18, 2019

@themygit the puzzle #666 is still not solved; solved: #667, #679.

@0pdd
Copy link
Collaborator

0pdd commented Jan 29, 2019

@themygit 2 puzzles #714, #715 are still not solved; solved: #666, #667, #679.

@0pdd
Copy link
Collaborator

0pdd commented Feb 6, 2019

@themygit 2 puzzles #714, #721 are still not solved; solved: #666, #667, #679, #715.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix from PO from product owner. It's hellxi x2 task's price doubled. Usually because of burning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@duker33 @themygit @ArtemijRodionov @0pdd