Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracking.es6:18: Move LoadedGATracker to the refarm. #761

Closed
0pdd opened this issue Mar 7, 2019 · 3 comments
Closed

tracking.es6:18: Move LoadedGATracker to the refarm. #761

0pdd opened this issue Mar 7, 2019 · 3 comments
Assignees
@ArtemijRodionov
Labels
1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix blocker this issue blocks another issue front markup or work with js Ya eCommerce feature

Comments

@0pdd
Copy link
Collaborator

0pdd commented Mar 7, 2019

The puzzle 759-bc6cfc4f from #759 has to be resolved:

shopelectro/front/js/shared/tracking.es6

Line 18 in 987327e

// @todo #759:30m Move LoadedGATracker to the refarm.

The puzzle was created by Artemiy on 07-Mar-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Mar 7, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Mar 7, 2019
@ArtemijRodionov
#759 google ecommerce (#760)
987327e 
* Remove dangling todo

* Dispatch gtm_loaded event

* Create PublishedGATracker class for GATracker

* Fix typo

* Review fixes

* Move class declaration upper than instantiation

* Apply linter rules
@0pdd 0pdd mentioned this issue Mar 7, 2019
Closed
@ArtemijRodionov ArtemijRodionov self-assigned this Mar 7, 2019
@ArtemijRodionov ArtemijRodionov added 30 mins middle-sized issue. Usually a part of feature or a fix 1 burning issue Ya eCommerce feature front markup or work with js labels Mar 7, 2019
@ArtemijRodionov ArtemijRodionov mentioned this issue Mar 12, 2019
Closed
@ArtemijRodionov ArtemijRodionov added the blocked issue is blocked by another issue label Mar 12, 2019
@ArtemijRodionov
Copy link
Contributor

It is blocked by #762

@ArtemijRodionov ArtemijRodionov added the blocker this issue blocks another issue label Mar 12, 2019
@ArtemijRodionov ArtemijRodionov mentioned this issue Mar 12, 2019
Closed
@ArtemijRodionov ArtemijRodionov removed the blocked issue is blocked by another issue label Mar 18, 2019
This was referenced Mar 24, 2019
Merged
Merged
ArtemijRodionov added a commit that referenced this issue Mar 26, 2019
@ArtemijRodionov
#761 #791 #780 Create gaLoader and move it to RF (#792)
6c30120 
* Create gaLoader and move it to RF

* Use reverse_custom_page from RF

* Bump rf version

* Add --no-cache for nodejs image

* Apply linter rules
@0pdd 0pdd mentioned this issue Mar 26, 2019
Open
@0pdd
Copy link
Collaborator Author

0pdd commented Mar 26, 2019

@0pdd the puzzle #795 is still not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 burning issue 30 mins middle-sized issue. Usually a part of feature or a fix blocker this issue blocks another issue front markup or work with js Ya eCommerce feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArtemijRodionov @0pdd