Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_selenium.py:395-397: Load the cart lazily. It will... #789

Closed
0pdd opened this issue Mar 24, 2019 · 4 comments
Closed

tests_selenium.py:395-397: Load the cart lazily. It will... #789

0pdd opened this issue Mar 24, 2019 · 4 comments
Assignees
@ArtemijRodionov
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue from PO from product owner. It's hellxi front markup or work with js x2 task's price doubled. Usually because of burning

Comments

@0pdd
Copy link
Collaborator

0pdd commented Mar 24, 2019

The puzzle 783-dbb67fb4 from #783 has to be resolved:

shopelectro/shopelectro/tests/tests_selenium.py

Lines 395 to 397 in 63cb15c

@todo #783:60m Load the cart lazily.
It will solve the issue with invalid cart data and
bring ability to create cache shared among users.

The puzzle was created by Artemiy on 24-Mar-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Mar 24, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Mar 24, 2019
@ArtemijRodionov
#783 test inconsistent cache issue (#787)
63cb15c 
* Create test for the inconsistent cache issue. Create todo to solve it

* Fix settings for test_cached_cart

* Review fixes

* Wrap test_cached_cart to expectedFailure
@0pdd 0pdd mentioned this issue Mar 24, 2019
Closed
@ArtemijRodionov ArtemijRodionov added 1 hour typical issue size. It's one pdd hour front markup or work with js labels Mar 24, 2019
@ArtemijRodionov ArtemijRodionov self-assigned this Mar 24, 2019
@ArtemijRodionov ArtemijRodionov added the 1 burning issue label Mar 24, 2019
@duker33 duker33 added the from PO from product owner. It's hellxi label Mar 24, 2019
@ArtemijRodionov ArtemijRodionov added the x2 task's price doubled. Usually because of burning label Mar 24, 2019
@ArtemijRodionov
Copy link
Contributor

I have faced with a weird django cache issue, so i'll increase the estimate

@ArtemijRodionov ArtemijRodionov mentioned this issue Mar 24, 2019
Merged
ArtemijRodionov added a commit that referenced this issue Mar 25, 2019
@ArtemijRodionov
#789 get cart route (#790)
10b86be 
* Create route to fetch Cart data

* Add url. Create test

* Create getCart on front

* Fix cache issue for cart-get route

* Add comment about middleware ordering

* Remove ETAG condition from Cart view

* Test Cache-Control: no-store for Cart view

* Remove dangling imports
This was referenced Mar 25, 2019
Open
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Mar 25, 2019

@0pdd 2 puzzles #793, #794 are still not solved.

0pdd referenced this issue Mar 29, 2019
@ArtemijRodionov
#794 lazy cart (#797)
7dbf2c1 
* Remove skip for test

* Load cart lazily

* Apply linter rules
@0pdd
Copy link
Collaborator Author

0pdd commented Mar 29, 2019

@0pdd the puzzle #793 is still not solved; solved: #794.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue from PO from product owner. It's hellxi front markup or work with js x2 task's price doubled. Usually because of burning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duker33 @ArtemijRodionov @0pdd