Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

headerCart.es6:11-12: Load cart lazily. See the parent... #794

Closed
0pdd opened this issue Mar 25, 2019 · 1 comment
Closed

headerCart.es6:11-12: Load cart lazily. See the parent... #794

0pdd opened this issue Mar 25, 2019 · 1 comment
Assignees
@ArtemijRodionov
Labels
1 hour typical issue size. It's one pdd hour 1 burning issue from PO from product owner. It's hellxi front markup or work with js

Comments

@0pdd
Copy link
Collaborator

0pdd commented Mar 25, 2019

The puzzle 789-a1cd638b from #789 has to be resolved:

shopelectro/front/js/components/headerCart.es6

Lines 11 to 12 in 10b86be

// @todo #789:60m Load cart lazily.
// See the parent task for details.

The puzzle was created by Artemiy on 25-Mar-19.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Mar 25, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Mar 25, 2019
@ArtemijRodionov
#789 get cart route (#790)
10b86be 
* Create route to fetch Cart data

* Add url. Create test

* Create getCart on front

* Fix cache issue for cart-get route

* Add comment about middleware ordering

* Remove ETAG condition from Cart view

* Test Cache-Control: no-store for Cart view

* Remove dangling imports
This was referenced Mar 25, 2019
Closed
Closed
@ArtemijRodionov ArtemijRodionov added 1 hour typical issue size. It's one pdd hour 1 burning issue from PO from product owner. It's hellxi front markup or work with js labels Mar 25, 2019
@ArtemijRodionov ArtemijRodionov self-assigned this Mar 25, 2019
@ArtemijRodionov ArtemijRodionov mentioned this issue Mar 28, 2019
Merged
ArtemijRodionov added a commit that referenced this issue Mar 29, 2019
@ArtemijRodionov
#794 lazy cart (#797)
7dbf2c1 
* Remove skip for test

* Load cart lazily

* Apply linter rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemijRodionov ArtemijRodionov

Labels
1 hour typical issue size. It's one pdd hour 1 burning issue from PO from product owner. It's hellxi front markup or work with js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArtemijRodionov @0pdd