Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tile_products.html:19-20: Remove product tile cards code... #975

Closed
0pdd opened this issue Sep 28, 2019 · 5 comments
Closed

tile_products.html:19-20: Remove product tile cards code... #975

0pdd opened this issue Sep 28, 2019 · 5 comments
Assignees
@olegush
Labels
2 performer can implement issue at his closest convenient time 15 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable front markup or work with js

Comments

@0pdd
Copy link
Collaborator

0pdd commented Sep 28, 2019

The puzzle 971-a1bdb68c from #971 has to be resolved:

shopelectro/templates/layout/tile_products.html

Lines 19 to 20 in 77991fd

@todo #971:60m Remove product tile cards code doubling.
Both in html templates and styles.

The puzzle was created by duker33 on 28-Sep-19.

Estimate: 60 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Sep 28, 2019

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Sep 28, 2019
@duker33
#971,969 Seo fixes from 25.09.19 (#972)
77991fd 
* #971  Fix contacts page styles

* #971  Fix tile-about text about accums

* #971  Fix subcategories sorting

* #971  Add "Add to cart" button for the product tile

* #971  Rm doubled data from the product microdata

* #971  Subtask top menu subcategories sorting

* #971  Fix search icon in header

* #971  Grade refarm to 0.7.2
@0pdd 0pdd mentioned this issue Sep 28, 2019
Closed
@duker33 duker33 added 1 hour typical issue size. It's one pdd hour 2 performer can implement issue at his closest convenient time cleanup everything that do project stronger, flexible, reusable front markup or work with js labels Sep 28, 2019
@olegush
Copy link
Collaborator

olegush commented Nov 4, 2019

Expalin the issue plz. I found the tile cards code in the tile_products.html only. And includes in product_404.html, product.html and index.html

@duker33
Copy link
Contributor

duker33 commented Nov 4, 2019

@olegush , y, seems code doubling is avoided already. Plz rm the task body from the code. You can do it in one of your's already opened PRs

@duker33 duker33 added 15 mins small issues. Usually cosmetic fixes and removed 1 hour typical issue size. It's one pdd hour labels Nov 4, 2019
@duker33
Copy link
Contributor

duker33 commented Nov 4, 2019

@olegush , 15 mins is your compensation for the task

olegush added a commit to olegush/shopelectro that referenced this issue Nov 4, 2019
@olegush
removed task body fidals#975 from the code
e2f1423
@olegush
Copy link
Collaborator

olegush commented Nov 4, 2019

Done

@duker33 duker33 closed this as completed Nov 4, 2019
olegush added a commit to olegush/shopelectro that referenced this issue Nov 18, 2019
@olegush
removed task body fidals#975 from the code
00b1e7a
0pdd referenced this issue Nov 19, 2019
@olegush
#1012 Avoided hardcoded values in RSS template (#1019)
4e7b782 
* fix template

* fix rss template

* add the test

* update settings

* update view

* rename rss to xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olegush olegush

Labels
2 performer can implement issue at his closest convenient time 15 mins small issues. Usually cosmetic fixes cleanup everything that do project stronger, flexible, reusable front markup or work with js
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@duker33 @0pdd @olegush