Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoided hardcoded values in RSS template #1012

Closed
wants to merge 10 commits into from
Closed

Avoided hardcoded values in RSS template #1012

wants to merge 10 commits into from

Conversation

olegush
Copy link
Collaborator

@olegush olegush commented Nov 1, 2019 •
edited

Closes #1009

@olegush olegush changed the title Avoid hardcoded values in RSS template Avoided hardcoded values in RSS template Nov 1, 2019
@olegush olegush requested a review from duker33 November 1, 2019 09:24
@duker33
Copy link
Contributor

duker33 commented Nov 5, 2019

@olegush , append plz PR body with the related task in format Closes #XXX

duker33
duker33 requested changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@duker33 duker33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor cleanups

shopelectro/management/commands/price.py Outdated
@@ -221,3 +223,4 @@ def handle(self, *args, **options):
template_path='prices/price.rss',
)
]).create()
print('context',Context('GM').context())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant print

shopelectro/settings/base.py Outdated
@@ -333,7 +333,8 @@ def get_robots_content():
'slug': '',
'name': 'Интернет-магазин элементов питания "ShopElectro"',
'menu_title': 'Главная',
'title': 'Интернет-магазин Элементов питания с доставкой по России',
'title': 'Интернет-магазин элементов питания с доставкой по России',
'description': 'Элементы питания в СПб с доставкой по России - интернет магазин элементов питания ShopElectro',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'description': 'Элементы питания в СПб с доставкой по России - интернет магазин элементов питания ShopElectro',
'description': 'Элементы питания в СПб с доставкой по России - интернет-магазин элементов питания ShopElectro',

@duker33
Copy link
Contributor

duker33 commented Nov 5, 2019

@olegush , write the test just for title tag plz. To do it plz clone and customize that one shopelectro.tests.tests_commands.PricesTest.test_items_in_price_rss

@olegush olegush requested a review from duker33 November 8, 2019 07:55
duker33
duker33 requested changes Nov 10, 2019
View reviewed changes
Copy link
Contributor

@duker33 duker33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems you removed Readme.md. Return it back plz :)

@olegush olegush requested a review from duker33 November 10, 2019 06:03
@olegush olegush closed this Nov 15, 2019
@olegush olegush reopened this Nov 15, 2019
@olegush
Copy link
Collaborator Author

olegush commented Nov 15, 2019 •
edited

Closed by the CI failure reason:

+ git init
Initialized empty Git repository in /drone/shopelectro/.git/
+ git remote add origin https://github.com/fidals/shopelectro.git
+ git fetch --no-tags origin +refs/pull/1012/merge:
fatal: Couldn't find remote ref refs/pull/1012/merge

@olegush olegush closed this Nov 15, 2019
@olegush olegush mentioned this pull request Nov 18, 2019
Merged
olegush added a commit that referenced this pull request Nov 19, 2019
@olegush
#1012 Avoided hardcoded values in RSS template (#1019)
4e7b782 
* fix template

* fix rss template

* add the test

* update settings

* update view

* rename rss to xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duker33 duker33 Awaiting requested review from duker33

Assignees

@olegush olegush

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avoid hardcoded values in RSS template. Take values like...
2 participants
@olegush @duker33