Set of minor cleanup fixes #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duker33
force-pushed
the
se_minor_fixes
branch
from
3a13c7c
to
37d9ebf
Compare
ArtemijRodionov
approved these changes
Dec 20, 2018
| @@ -276,6 +276,9 @@ def merge(left: List, right: List) -> List: | |||
| for field, value in product_data.items(): | |||
| save(product, field, value) | |||
| product.save() | |||
| # if 1C contains product, it should be inactive at DB | |||
There was a problem hiding this comment.
The comment isn't clear. Why a product should be inactive at the DB if it is contained at 1C? It seems to me it should be active, shouldn't it?
There was a problem hiding this comment.
@artemiy312 , it should be active, of course, sorry. I'll fix it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #655
Closes #662
Closes #667
Closes #669