Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests_commands.py:176-177: Refactor huge set of getters... #667

Closed
0pdd opened this issue Dec 11, 2018 · 3 comments
Closed

tests_commands.py:176-177: Refactor huge set of getters... #667

0pdd opened this issue Dec 11, 2018 · 3 comments
Assignees
@duker33
Labels
3 we can defer this issue. But it'll good to implement it 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable

Comments

@0pdd
Copy link
Collaborator

0pdd commented Dec 11, 2018

The puzzle 661-57422015 from #661 has to be resolved:

shopelectro/shopelectro/tests/tests_commands.py

Lines 176 to 177 in 2f19548

# @todo #661:30m Refactor huge set of getters in prices test.
# Move every `get_price_...` method to some `PriceNode` class.

The puzzle was created by duker33 on 11-Dec-18.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
@0pdd
Copy link
Collaborator Author

0pdd commented Dec 11, 2018

@artemiyds2 @duker33 please pay attention to this new issue.

0pdd referenced this issue Dec 11, 2018
@duker33
#661 Change utm for YaMarket's price.yml (#664)
2f19548 
* #661  Refactor constant name

* #661  Move utm patching to explicit data structure

* #661  Move utm patching to explicit data structure

* #661  Apply linter rules
@0pdd 0pdd mentioned this issue Dec 11, 2018
Closed
@duker33 duker33 added 30 mins middle-sized issue. Usually a part of feature or a fix 3 we can defer this issue. But it'll good to implement it take it any teammate can take this issue and start working with it cleanup everything that do project stronger, flexible, reusable labels Dec 11, 2018
@duker33 duker33 self-assigned this Dec 17, 2018
@duker33 duker33 removed the take it any teammate can take this issue and start working with it label Dec 17, 2018
duker33 added a commit that referenced this issue Dec 19, 2018
@duker33
#667 Refactor set of getters in price tests
73c35e9
@duker33 duker33 mentioned this issue Dec 19, 2018
Merged
duker33 added a commit that referenced this issue Dec 19, 2018
@duker33
#667 Refactor set of getters in price tests
32bc421
duker33 added a commit that referenced this issue Dec 20, 2018
@duker33
Set of minor cleanup fixes (#676)
50ee0ad 
* #662  Rm ExcludedModelPage

* #662  Return is_active to it's initial state

* #667  Refactor set of getters in price tests

* #669  Fix product pages consistency at update_db command

* #669  Apply linter rule

* #fix  Fix mistake at comments
@0pdd 0pdd mentioned this issue Dec 20, 2018
Closed
@0pdd
Copy link
Collaborator Author

0pdd commented Dec 20, 2018

@0pdd the puzzle #679 is still not solved.

@0pdd
Copy link
Collaborator Author

0pdd commented Jan 18, 2019

@0pdd the only puzzle #679 is solved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@duker33 duker33

Labels
3 we can defer this issue. But it'll good to implement it 30 mins middle-sized issue. Usually a part of feature or a fix cleanup everything that do project stronger, flexible, reusable
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@duker33 @0pdd