Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading + disabled state should apply disabled button styles #13258

Open
johnbacon opened this issue Jun 14, 2024 · 0 comments
Open

Loading + disabled state should apply disabled button styles #13258

johnbacon opened this issue Jun 14, 2024 · 0 comments
Labels
bug Something isn't working confirmed medium priority
Milestone

Comments

@johnbacon
Copy link

johnbacon commented Jun 14, 2024

Package

filament/filament

Package Version

Latest (v3)

Laravel Version

v10.x

Livewire Version

Latest (v3)

PHP Version

PHP 8.1.x

Problem description

Using form builder,1, when a form is submitted and submit button is in loading state, disabled=true is set but disabled styling is not applied.

Expected behavior

The disabled button, when in the loading state, will have both the default cursor style and the opacity associated with a disabled button:

'pointer-events-none opacity-70' => $disabled,

Steps to reproduce

Using form builder, build a form, submit it with the button in loading state, and take a look!

Reproduction repository (issue will be closed if this is not valid)

https://github.com/filamentphp/demo

Relevant log output

No response

Donate 💰 to fund this issue

  • You can donate funding to this issue. We receive the money once the issue is completed & confirmed by you.
  • 100% of the funding will be distributed between the Filament core team to run all aspects of the project.
  • Thank you in advance for helping us make maintenance sustainable!
Fund with Polar

Footnotes

  1. And possibly in other instances, this is only where we encountered it.

@zepfietje zepfietje added this to the v3 milestone Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed medium priority
Projects
Status: Todo
Development

No branches or pull requests

2 participants