Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amc script rename step optimization #36

Closed
queimadus opened this issue Oct 12, 2016 · 2 comments
Closed

amc script rename step optimization #36

queimadus opened this issue Oct 12, 2016 · 2 comments

Comments

@queimadus
Copy link

The default behaviour of the rename step is to use what was specified in the --action argument.

But even if the user specified copy as that action, when temporary files are created (e.g. the target was a zip file instead of a singular video file), this can be optimized to a move if cleanis enabled since it will be deleted afterwards anyhow.

This would avoid doing an unnecessary copy.

@rednoah
Copy link
Member

rednoah commented Oct 12, 2016

If input/output are on different filesystems, you won't get around making a physical copy.
If input/output are on the same filesystem then you should be using --action hardlink anyway.

The --action duplicate option is used in all examples to avoid the inefficiencies of physical copy operations if avoidable.

@queimadus
Copy link
Author

I was unaware of --action duplicate. It completely mitigates the issue at hand.

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants