Update fip-0059.md (Updating the synthetic challenge generation function) #951
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the synthetic challenge generation function (it was changed during the code audit but at the time we forgot to update the fip, so I am doing it now)
irenegia
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle,
anorth,
raulk,
jsoares and
TippyFlitsUK
as code owners
jsoares
approved these changes
Feb 23, 2024
There was a problem hiding this comment.
Thank you for going back and fixing the spec! I also noticed the FIP was merged without an implementation reference. There are a number of component PRs involved, so maybe link the overall tracking issue filecoin-project/lotus#10984 ?
done |
anorth
approved these changes
Feb 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function proposed in the fip was changed during the code audit but at the time we forgot to update the fip, so I am doing it now.