Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement SynthPoRep #10984

Closed
18 tasks done
Tracked by #10340
rjan90 opened this issue Jun 14, 2023 · 12 comments · Fixed by #11258
Closed
18 tasks done
Tracked by #10340

Implement SynthPoRep #10984

rjan90 opened this issue Jun 14, 2023 · 12 comments · Fixed by #11258
Milestone

Comments

@rjan90
Copy link
Contributor

rjan90 commented Jun 14, 2023

WIP tracking issue for SynthPoReps: https://github.com/filecoin-project/FIPs/blob/master/FIPS/fip-0059.md

User story

  • As a storage provider (SP) I want to leverage SynthethicPoReps to reduce the temporary data stored between PreCommit and ProveCommit from ~400GiB to ≤ 25GiB.

Acceptence criteria (SP):

  • Can be enabled by setting SynthPoRep=true in the config.toml file
  • All sector types sealed with SynthPoRep passes WindowPoSt/WinningPoSt

Acceptence criteria (SaaS):

Techincal scope

Synthetic PoRep Development

  1. snadrus

We also need to introduce a network upgrade to introduce synthetic porep, thus we need to implement the barebone for nv21 in lotus to unblock testing.

add barebone nv21

  1. 1 of 1
    magik6k rjan90

Testing

Deliverable

Current proposals for the network upgrade timeline can be seen here: filecoin-project/core-devs#140 (comment)

@jennijuju
Copy link
Member

on acceptance criteria, I would break it down by SaaS provider and individual SP.

@jennijuju
Copy link
Member

added fvm and actor development handoff issue & added a tasklist for add barebone nv21 - without it, we wont be able to test the synthetic porep work.

@jennijuju
Copy link
Member

May I get an update on the status?

@jennijuju
Copy link
Member

jennijuju commented Jul 6, 2023

Latest update from @cryptonemo

filecoin-project/rust-fil-proofs#1711 (comment) - open by Jul 7th.

@jennijuju
Copy link
Member

Should we at least include ONE SaaS provider in the testing plan (butterfly might be a good idea), unless we believe the regular SP pipeline would fully cover that too.

@jennijuju
Copy link
Member

@snadrus once the actor and fvm code is ready, Andy will continue #10970 in this sprint

@jennijuju
Copy link
Member

We are hoping to have a deployable butterfly that accepts SythPoRep by the end of. the sprint (July 17th)

@jennijuju
Copy link
Member

@rjan90 can I get a status update on this, how is testing going? are we close to landing PRs to nv integration branch?

@rjan90
Copy link
Contributor Author

rjan90 commented Aug 24, 2023

Status update:

  • I would say that testing on the butterfly-network for SynthPoReps can be called completed 🟢: feat: introduce SyntheticPoRep #11057 (comment)
    • Testing verified deals on Butterfly has been hard, due to rkh-keys being hard to surface. That said SynthPoRep FIL+ sectors was tested to be successful on a 2k-network.
      • Want to confirm new FIL+ flow with DDO, so resurfacing these test-cases in the mid-september Butterfly-reset makes more sense.
    • Bug for extending SynthPoRep sectors has landed. fix: Add SynthPoReps to SealProofPoliciesV11 go-state-types#200. Confirming this fix on a local devnet will be easier once SynthPoRep is being merged into feat/nv21

Next steps:

  • Get reviews and land dependencies in their nv21 specific branches.
  • Rebase the Lotus introduce SynthPoRep PR to be based off v1.23.3, and get it reviewed.

@rjan90 rjan90 linked a pull request Aug 31, 2023 that will close this issue
13 tasks
@rjan90
Copy link
Contributor Author

rjan90 commented Sep 20, 2023

Closing this ticket now that the SynthPoRep-code has landed in the feat/nv21 branch..

Outstanding item from this epic, that can be seperated into their own tickets as they are more timeline dependent.

@rjan90 rjan90 closed this as completed Sep 20, 2023
@cryptonemo
Copy link
Contributor

* Blog post/media for explaining why all SPs want to use this [luca/irene/nemo]. In draft, but should be published closer to the Calibration-network upgrade IMO

FYI, draft is being finalized this week and we are scheduled for blog post release on Oct 3

@rjan90 rjan90 linked a pull request Sep 20, 2023 that will close this issue
8 tasks
@rjan90
Copy link
Contributor Author

rjan90 commented Sep 20, 2023

Awesome @cryptonemo! Perfect timing👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
3 participants